feat: Make notarization with Apple ID more usable #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we supported notarizing with the legacy `altool` or the new `notarytool` API. The legacy tool has since been decommissioned. 1. Look at `APPLE_TEAM_ID` environment variable for getting the team to notarize as. Previously, when authenticating with an Apple ID, this property was used to determine whether to notarize with the old or new API. It's confusing to have the authentication split across these two places. 2. Mark legacy notarize API as deprecated and remove old validation.
🦋 Changeset detectedLatest commit: fa6ee83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rotu
changed the title
|
Fixes #7812 |
|
Committing that isn't enough, you have to edit the PR description (or add it as a linked issue). |
|
@NoahAndrews Hello, can this be merged? |
|
I'm not a maintainer, just trying to help out occasionally |
|
@mmaietta Hello, can this PR be merged now? |
|
Thanks for your contribution @rotu! Really appreciate it Sure thing, will get this merged and released asap 🙂 |
mnvr
added a commit
to ente-io/ente
that referenced
this pull request
May 3, 2024
We need the following patch (from the release notes of v25.0.0-alpha.6) https://github.com/electron-userland/electron-builder/releases > feat: Make notarization with Apple ID more usable by > electron-userland/electron-builder#8159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we supported notarizing with the legacy
altoolor the newnotarytoolAPI. The legacy tool has since been decommissioned.APPLE_TEAM_IDenvironment variable for getting the team to notarize as. Previously, when authenticating with an Apple ID, this property was used to determine whether to notarize with the old or new API. It's confusing to have the authentication split across these two places.Fixes #7812