Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mac): support macos signature additionalArguments parameter #8218

Merged
merged 4 commits into from
May 20, 2024

Conversation

PBK-B
Copy link
Contributor

@PBK-B PBK-B commented May 15, 2024

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 17fd5e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 15, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 17fd5e5
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/664b691d1e83250008a083e0
😎 Deploy Preview https://deploy-preview-8218--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator

Thanks for your contribution! Could you please update electron/osx-sign package as part of the PR? Looks like we're pinned to 1.0.5

@PBK-B
Copy link
Contributor Author

PBK-B commented May 15, 2024

Oh, damn it, I forgot to submit the package.json file. Thank you for reminding me @mmaietta

@PBK-B
Copy link
Contributor Author

PBK-B commented May 15, 2024

Due to the higher pnpm version of the local environment, the pnpm-lock.yaml file has been greatly changed, so I choose to ignore the submission of the file (thus may lead to the failure of ci). If there is anything that can help, I can cooperate.

@mmaietta
Copy link
Collaborator

I gotcha. Updated the pnpm-lock.yaml and added a changeset

@mmaietta mmaietta merged commit 22737b2 into electron-userland:master May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants