fix: binary checking

[beyondkmp]

If a module contains a folder with a name like test.app or test.framework, and there are binary files inside, it will be incorrectly processed and the module will be placed in app.asar instead of being smartly unpacked into app.asar.unpacked.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4695d7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	4695d7f
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/668e1a28e56cee00088717c9
😎 Deploy Preview	https://deploy-preview-8310--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[beyondkmp]

@mmaietta I'm curious why these files are being checked separately. They should all be binary files as well.

moduleName === "ffprobe-static" || moduleName === "ffmpeg-static" || isLibOrExe(file)

Do you know why this is happening? This approach doesn't seem very smart.

[mmaietta]

@mmaietta I'm curious why these files are being checked separately. They should all be binary files as well.

moduleName === "ffprobe-static" || moduleName === "ffmpeg-static" || isLibOrExe(file)

Do you know why this is happening? This approach doesn't seem very smart.

Honestly, I don't know either. That logic predates me joining the maintainer crew.

[mmaietta]

Side note, thank you @beyondkmp for all your contributions! I really appreciate all the efforts you've been doing to help improve electron-builder (and app-builder as well)!

[beyondkmp]

@mmaietta I have a question: how can I become a maintainer?

[mmaietta]

If you have discord, contact me at onegoldfish and we can chat further and be able to stay more in sync for collaboration 😃