Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron-updater,deb): Handle spaces in application artifact name for deb #8400

Conversation

Ryan432
Copy link
Contributor

@Ryan432 Ryan432 commented Aug 5, 2024

No description provided.

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 2146fd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 2146fd4
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66b1f6edcc26430008389307
😎 Deploy Preview https://deploy-preview-8400--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ryan432 Ryan432 changed the title fix(electron-updater,deb): Fix Linux deb auto updater install command. fix(electron-updater,deb): Handle spaces in application artifact name for deb Aug 6, 2024
Copy link
Contributor

@xyloflake xyloflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready for review from @mmaietta imo

@xyloflake
Copy link
Contributor

@Ryan432 you should prolly add a changeset btw

@Ryan432
Copy link
Contributor Author

Ryan432 commented Aug 6, 2024

@Ryan432 you should prolly add a changeset btw

Not sure what you mean by changeset.

@xyloflake
Copy link
Contributor

xyloflake commented Aug 6, 2024

@Ryan432 you should prolly add a changeset btw

Not sure what you mean by changeset.

Have a look at the comment made by the changeset bot.

#8400 (comment)

@Ryan432
Copy link
Contributor Author

Ryan432 commented Aug 6, 2024

@Ryan432 you should prolly add a changeset btw

Not sure what you mean by changeset.

Have a look at the comment made by the changeset bot.

#8400 (comment)

changeset added.

@mmaietta mmaietta merged commit 9dc0b49 into electron-userland:master Aug 6, 2024
13 checks passed
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
@Ryan432 Ryan432 deleted the Fix-linux-deb-updater-install-command branch August 7, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants