Skip to content

Commit

Permalink
fix: reset node env earlier during shutdown (#23069)
Browse files Browse the repository at this point in the history
Co-authored-by: Jeremy Apthorp <[email protected]>
  • Loading branch information
trop[bot] and nornagon committed Apr 13, 2020
1 parent c3340ad commit 7316ebd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions shell/browser/electron_browser_main_parts.cc
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
// Destroy node platform after all destructors_ are executed, as they may
// invoke Node/V8 APIs inside them.
node_debugger_->Stop();
node_env_.reset();
js_env_->OnMessageLoopDestroying();

fake_browser_process_->PostMainMessageLoopRun();
Expand Down

0 comments on commit 7316ebd

Please sign in to comment.