Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITable #36

Open
ievgen-boink opened this issue May 28, 2021 · 1 comment
Open

ITable #36

ievgen-boink opened this issue May 28, 2021 · 1 comment
Labels
needs triage

Comments

@ievgen-boink
Copy link

ievgen-boink commented May 28, 2021 •
edited

Describe the bug
Seeder property table expects Table, but if want to retrieve already existing table ( fromTableArn or fromTableAttributes) - all these methods return ITable
It will be small fix to replace it:
Screen Shot 2021-05-28 at 12 45 26 PM
@ievgen-boink ievgen-boink changed the title Empty bucket ITable May 28, 2021
rheinardkorf pushed a commit to rheinardkorf/aws-cdk-dynamodb-seeder that referenced this issue Jun 10, 2021
Replaces Table class with ITable interface.
d4e43f7 
This commit addresses issue elegantdevelopment#36.

The Seeder works for new tables being created via CDK, but existing tables
using `fromTableArn` or `fromTableAttributes` fail.

Changing the Props type to ITable allows for new and existing tables.

**Tests**
Tests still pass successfully with this change.
@rheinardkorf rheinardkorf mentioned this issue Jun 10, 2021
Open
@rheinardkorf
Copy link

@ievgen-boink I have faced the same issue. Thanks for highlighting the solution.

I've created a PR to fix this. 🤞 for a quick review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rheinardkorf @ievgen-boink