New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket security props #34

Open

tmarcinkowski-logitech wants to merge 2 commits into elegantdevelopment:master from Logitech:fix/s3-bucket-security

tmarcinkowski-logitech commented May 17, 2021

I've added additional props to the created bucket:

enforcing SSL
enabling server-side encryption
disabling public access to the bucket

That's the standard we're using in our company and, frankly, I see no reason not to apply it to any other project.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

tmarcinkowski-logitech added 2 commits

May 17, 2021 09:57


          dependencies update

95cb8e7


          added security related props for the bucket

d558610

Author

tmarcinkowski-logitech commented Jun 23, 2021

@jsdtaylor can you take a look at this and either provide feedback or merge and release it, please? we don't want to rely on my fork in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment