Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateManager: remove runtime size check #2180

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jun 20, 2024

Fixes runtime updates not showing in updates list

This size check was added here, But we no longer create a "No runtime updates" package so we don't need this. A package is only inserted into the list if we find updates already

@danirabbit danirabbit requested a review from a team June 20, 2024 17:30
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang you found the cause quick. The fix works a treat!

@danirabbit
Copy link
Member Author

I've been digging around in this muck for a bit now 😅 Thanks for the quick review!

@danirabbit danirabbit merged commit e2e7280 into main Jun 20, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/updatemanager-rmruntimesizecheck branch June 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants