Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Permission tab of Application Settings #99

Conversation

meisenzahl
Copy link
Member

Related to #97

@meisenzahl
Copy link
Member Author

meisenzahl commented Aug 22, 2020

Screenshot von 2020-08-22 09 07 45

@meisenzahl
Copy link
Member Author

Screenshot von 2020-08-22 08 47 05

@danirabbit danirabbit added the Needs Design Waiting for input from the UX team label Aug 24, 2020
@danirabbit
Copy link
Member

Thanks for working on this! I'm looking at the pre-existing work we have in the GeoClue agent for displaying a link to system settings. It looks like the pattern there is to include a settings link in the body copy like this:

Screenshot from 2020-08-24 10 07 51@2x

Otherwise, if this button doesn't close the dialog it should be in the incidental action position like this:

Screenshot from 2020-08-24 10 11 43@2x

Or if it does close the dialog, it should be in the secondary action position like this:

Screenshot from 2020-08-24 10 12 21@2x

@cassidyjames any thoughts on which feels most natural?

@cassidyjames
Copy link
Contributor

I'm not sure we need to link to permissions settings in the first place, as I believe the plan is to expose/explain what permissions are being requested (and the implications) before installing. But if we do want to show it here, then I think the inline link feels the best to me.

@meisenzahl
Copy link
Member Author

Thanks for your feedback!

I have implemented the variant with the inline link.
If you like, you are welcome to use it :)

Screenshot von 2020-08-25 18 07 45

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice work!

@danirabbit danirabbit merged commit ad44a64 into elementary:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants