Add support for offline firmware updates (#244)

* FirmwareClient: Set default install flags * FirmwareView: Check if device can only do offline updates
elementary · Feb 8, 2022 · d9e8661 · d9e8661
1 parent e539e1d
commit d9e8661
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Interfaces/FirmwareClient.vala b/src/Interfaces/FirmwareClient.vala
@@ -68,14 +68,14 @@ public class About.FirmwareClient {
         return releases;
     }
 
-    public static async bool install (Fwupd.Client client, string device_id, string path) throws GLib.Error {
+    public static async bool install (Fwupd.Client client, string device_id, string path, Fwupd.InstallFlags install_flags = Fwupd.InstallFlags.NONE) throws GLib.Error {
         SourceFunc callback = install.callback;
         GLib.Error error = null;
         bool result = false;
 
         new Thread<void> ("install", () => {
             try {
-                result = client.install (device_id, path, Fwupd.InstallFlags.NONE);
+                result = client.install (device_id, path, install_flags);
             } catch (Error e) {
                 error = e;
             }

diff --git a/src/Views/FirmwareView.vala b/src/Views/FirmwareView.vala
@@ -252,7 +252,12 @@ public class About.FirmwareView : Granite.SimpleSettingsPage {
         var path = yield download_file (device, release.get_uri ());
 
         try {
-            if (yield FirmwareClient.install (fwupd_client, device.get_id (), path)) {
+            var install_flags = Fwupd.InstallFlags.NONE;
+            if (device.has_flag (Fwupd.DEVICE_FLAG_ONLY_OFFLINE)) {
+                install_flags = Fwupd.InstallFlags.OFFLINE;
+            }
+
+            if (yield FirmwareClient.install (fwupd_client, device.get_id (), path, install_flags)) {
                 if (device.has_flag (Fwupd.DEVICE_FLAG_NEEDS_REBOOT)) {
                     show_reboot_dialog ();
                 } else if (device.has_flag (Fwupd.DEVICE_FLAG_NEEDS_SHUTDOWN)) {