Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fwupd #150

Merged
merged 106 commits into from
Jan 25, 2021
Merged

Add support for fwupd #150

merged 106 commits into from
Jan 25, 2021

Conversation

meisenzahl
Copy link
Member

Closes #123

@cassidyjames cassidyjames added this to In progress in OEM-friendliness via automation Dec 10, 2020
meisenzahl and others added 15 commits December 10, 2020 20:37
danirabbit
danirabbit reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I noticed is that this introduces a significant lag when first opening the page. There are probably some operations that need to be made asynchronous from the view construction

src/Interfaces/FwupdManager.vala Outdated Show resolved Hide resolved
davidmhewitt
davidmhewitt requested changes Jan 21, 2021
View reviewed changes
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few comments

src/Interfaces/FwupdManager.vala Outdated Show resolved Hide resolved
src/Interfaces/FwupdManager.vala Outdated Show resolved Hide resolved
src/Interfaces/FwupdManager.vala Outdated Show resolved Hide resolved
src/Interfaces/FwupdManager.vala Outdated Show resolved Hide resolved
src/Widgets/FirmwareUpdateRow.vala Outdated Show resolved Hide resolved
@danirabbit danirabbit added this to In progress in 6.0 Odin Release via automation Jan 22, 2021
@danirabbit
Copy link
Member

I'm getting a real big lag when first opening the System plug again :(

@davidmhewitt
Copy link
Member

@danrabbit ah, oops, I wonder if that's related to my merge earlier. Does it go away if you install switcheroo-control. It might be timing out waiting for that.

@danirabbit
Copy link
Member

@davidmhewitt ah yup, I think that's it. Created #171

davidmhewitt
davidmhewitt approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the code, but I have not conducted any testing. Nice work @meisenzahl !

@meisenzahl
Copy link
Member Author

@davidmhewitt thank you for your reviews and constructive feedback.

danirabbit
danirabbit approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the testing I've done, I'm happy with this as an MVP. I think we can wait until follow ups to iterate on the design and add features. But this does the thing as far as I'm concerned:)

@meisenzahl
Copy link
Member Author

I created some issues:

Feel free to create some more if I missed something :)

cassidyjames
cassidyjames approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cassidyjames cassidyjames merged commit 932d4f1 into master Jan 25, 2021
OEM-friendliness automation moved this from In progress to Done Jan 25, 2021
6.0 Odin Release automation moved this from In progress to Done Jan 25, 2021
@cassidyjames cassidyjames deleted the add-support-for-fwupd branch January 25, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lainsce lainsce lainsce left review comments

@cassidyjames cassidyjames cassidyjames approved these changes

@davidmhewitt davidmhewitt davidmhewitt approved these changes

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Hardware Support
Status: Done
6.0 Odin Release
  
Done
OEM-friendliness
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for fwupd
5 participants
@meisenzahl @danirabbit @cassidyjames @davidmhewitt @lainsce