Add dark style toggle to indicator

[meisenzahl]

Closes #71

[meisenzahl]

@danrabbit What do you think of the layout?

Or do we want to create an own indicator for appearance? There we could also handle the accent color.

[meisenzahl]

Related to elementary/settings-daemon#15

[fabiozaramella]

In my opinion it looks a bit cramped but it's still better than a separate indicator, since dark mode goes "logically" better along with night light.

[danirabbit]

I think we should probably group the link items together at the bottom

And maybe dropping the separator between the slider and the switch would make these feel more logically grouped

[fabiozaramella]

What if we just drop the separator but keep the links divided? Since it makes sense for those to be separated.

[meisenzahl]

Like this?

[martinstork]

Quick phone edit:

Same order as the first image but separated by nightlight and dark mode might be an option.

[fabiozaramella]

How would it look as in @martinstork picture but keeping the separator between toggle/slider and the link to settings? Maybe it would looks better while still being relatively homogeneous to other indicators' style.

[meisenzahl]

How would it look as in @martinstork picture but keeping the separator between toggle/slider and the link to settings? Maybe it would looks better while still being relatively homogeneous to other indicators' style.

@fabiozaramella you mean like this?

[meisenzahl]

Here are 2 more layouts, though I am not satisfied with them myself

[fabiozaramella]

How would it look as in @martinstork picture but keeping the separator between toggle/slider and the link to settings? Maybe it would looks better while still being relatively homogeneous to other indicators' style.

@fabiozaramella you mean like this?

Exactly, I think it's a good compromise. 😅

[fabiozaramella]

@elementary/ux any opinion on this?

[cassidyjames]

I want to think about what we want to actually have in an indicator, and when; i.e. should it have a light/dark style selection, or just a snooze option when dark style is scheduled? It works a little differently than Night Light so I want to be sure we're doing what people would expect here.

[hanaral]

I want to think about what we want to actually have in an indicator, and when; i.e. should it have a light/dark style selection, or just a snooze option when dark style is scheduled? It works a little differently than Night Light so I want to be sure we're doing what people would expect here.

Maybe it shouldn't have a snooze at all? Since the dark style is not just something you toggle on and off like you would with a colour shift (in the case of colour checking). I think that the dark mode should only be able to be changed from Settings > Appearance, and that the indicator only has an obvious 'Dark Style Settings...' button.

[cassidyjames]

@hanaral I disagree. I toggle dark style on/off frequently on my phone depending on the context; e.g. if I bring my device into a dark room or outside into a bright environment. Having a quick toggle here would still be useful.

I think for a first go, we just stick to an option for dark or light, and have it disable the schedule if toggled. Then we can follow it up with smarter "snoozing" logic. So, something like:

--------------^---------------
| Snooze Night Light   (o-)  |
|                            |
| ☀️ --------------o-------  |
|                            |
|----------------------------|
|                            |
|        ☀️        🌑️        |
|      Default    Dark       |
|                            |
|----------------------------|
| Night Light Settings…      |
| Appearance Settings…       |
------------------------------

@danrabbit you had mentioned providing icons or illustrations at a smaller size for this, I think?

[hanaral]

@hanaral I disagree. I toggle dark style on/off frequently on my phone depending on the context; e.g. if I bring my device into a dark room or outside into a bright environment. Having a quick toggle here would still be useful.

Hmm, I see. My argument was based on the idea that the environment wouldn't change, but I can see that moving a device around would require it.

Edit: I just thought about this, but shouldn't alot of the Appearance, Display and Locking related settings panels be rethought a little?
I've opened an issue here

[ChildishGiant]

I just spent the whole day making my own indicator, without checking if someone has already done it 🤦
https://github.com/ChildishGiant/wingpanel-indicator-dark-style