Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a GLib.ListStore to handle the notifications. #169

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use a GLib.ListStore to handle the notifications. #169

wants to merge 3 commits into from

Conversation

tintou
Copy link
Member

@tintou tintou commented Nov 6, 2020 •
edited
Loading

Changes:

  • Make the Notification object the center of the logic
  • Avoid the use of static and get_default when it's not necessary
  • A GLib.ListStore allows to ensure that everything is in sync
  • Make AppEntry a header of the Gtk.ListView
  • Make the most things private or declared in its block if not re-used

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 7, 2020

I guess this will make some of the other PRs redundant ...

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 7, 2020

Compiles and runs OK. Seems like a good idea. Changes order of notifications so that most recent at bottom - is that intended?

MASTER
Notifications-master

THIS PR
Notifications-bind_model

jeremypw
jeremypw requested changes Nov 7, 2020
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New notifications get added to the bottom of the list even if an appropriate header is available so you can get duplicate headers.

New Notification - bind_model

@jeremypw jeremypw mentioned this pull request Nov 17, 2020
Merged
@danirabbit danirabbit mentioned this pull request Apr 22, 2021
Merged
@jeremypw
Copy link
Collaborator

jeremypw commented Mar 6, 2022

@tintou Any chance of progressing this one?

@leolost2605 leolost2605 mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw requested changes

@danirabbit danirabbit Awaiting requested review from danirabbit

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Conflicts with master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tintou @jeremypw @danirabbit