Remove Session.vala
#265
Open
Remove Session.vala
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
session storage while using the org.freedesktop.Notifications interface is flawed and broken. notifications can't be closed by apps and actions cannot be activated after the application exits or there's a system reset. so remove the between session capabilities from the indicator. Signed-off-by: Gustavo Marques <[email protected]>
Marukesu
force-pushed
the
maru/remove-session
branch
from
79c5859
to
b326092
Compare
|
I'm -1 on removing this functionality. There can still be valuable information in an old notification even if the notification itself can't be actioned on |
|
The idea here was more of "remove it temporary, and restore after support for the portal/GTK interfaces was added in the server". Given that the notification format is different between those interfaces and the fdo interface, a rewrite of the session file will be needed anyway. the biggest problem with the between sessions persistence and the fdo interface are that applications cannot remove they notifications after a reboot or being closed, so the user need to be constantly cleaning-up the indicator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session storage while using the org.freedesktop.Notifications interface is flawed and broken. notifications can't be closed by apps and actions cannot be activated after the application exits or there's a system reset. so remove the between session capabilities from the indicator.
we can restore between session persistence in the server, after it has direct support to the Gtk/Portal interfaces. but for now, i think it's better to be honest here and remove it.