Building in OSX. Support both for gcc-c++ and clang++ (with openMP) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 1, 2019 12:38
…SX into common NON-Windows case OSX is not glibc, but execinfo.h has everything needed here.
…Added AR variable to be appropriately redefined for the specific platform
…ormation for the gtest libraries path from the environment
… directly, that make its incompatible with clang. Fix: Substituted by CFLAGS, that have correct openmp switch
…milies gcc-c++ and clang++
mrtuborg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Sir,
I want to propose my pull request, that helped to work with your library on my computer (macOS). Probably it will be useful for others.
I did not switched off any parts of your code to be able to compile it under osx and/or clang++, but just found appropriate system call for it.
I did the best I can to check if it still building in Linux. I was able to run all the tests described in README.md with gcc 8.1
Unfortunately, I see some issues while I am trying to compile tests with clang++ or gcc v8.3:
Here the log: make tests log
I think it have sense to fix it in separate pull request to avoid too much work for reviewers.
Faithfully yours,
Vladimir.