Remove ExpandoObject support from JintJavaScriptEvaluator

Removed the `ConverterHelper` and `ExpandoObjectConverter` classes, along with their integration in `JintJavaScriptEvaluator`. Updated unit tests to skip unsupported functionality and added references to related issues for context.
elsa-workflows · Aug 19, 2024 · baaf2f4 · baaf2f4
1 parent 8917bd9
commit baaf2f4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 84 deletions.
diff --git a/src/modules/Elsa.JavaScript/Helpers/ConverterHelper.cs b/src/modules/Elsa.JavaScript/Helpers/ConverterHelper.cs
diff --git a/src/modules/Elsa.JavaScript/ObjectConverters/ExpandoObjectConverter.cs b/src/modules/Elsa.JavaScript/ObjectConverters/ExpandoObjectConverter.cs
diff --git a/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs b/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs
@@ -81,7 +81,7 @@ private void ConfigureObjectWrapper(Jint.Options options)
 
     private void ConfigureObjectConverters(Jint.Options options)
     {
-        options.Interop.ObjectConverters.AddRange([new ByteArrayConverter(), new ExpandoObjectConverter()]);
+        options.Interop.ObjectConverters.AddRange([new ByteArrayConverter()]);
     }
 
     private void ConfigureArgumentGetters(Engine engine, ExpressionEvaluatorOptions options)

diff --git a/test/integration/Elsa.Workflows.IntegrationTests/Scenarios/JavaScriptListsAndArrays/Tests.cs b/test/integration/Elsa.Workflows.IntegrationTests/Scenarios/JavaScriptListsAndArrays/Tests.cs
@@ -80,9 +80,11 @@ public async Task Test2()
         Assert.Equal(43, magicNumber);
     }
 
-    [Theory(DisplayName = "Can sort array and list properties as mutable arrays")]
+    [Theory(DisplayName = "Can sort array and list properties as mutable arrays", Skip = "Not supported yet. See https://github.com/elsa-workflows/elsa-core/issues/5912")]
     [MemberData(nameof(ArraySortEnumerableData))]
-    // See also: https://github.com/sebastienros/jint/issues/1942
+    // See also:
+    //  - https://github.com/sebastienros/jint/issues/1942
+    //  - https://github.com/elsa-workflows/elsa-core/issues/5912
     public async Task Test5(IEnumerable<double> collection)
     {
         dynamic dynamicObject = new ExpandoObject();