Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NUKE build support #4815

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Add NUKE build support #4815

merged 1 commit into from
Jan 21, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Jan 19, 2024

This is the first step to add minimal NUKE build support. You're using some advanced GitHub Actions definitions, so it's not that easy to shift logic from them to the C# build. As first iteration I'm suggesting to move the build part to calling the NUKE infrastructure and generating the PR template that will be run against any PRs for this repo.

I removed the duplicate projects from the solution file as NUKE wasn't too happy about them. Also let Visual Studio open the file and update project GUIDs and fixed projects locations. After solution was saved Rider no longer complained about project loading problems either.

@lahma lahma force-pushed the nuke branch 6 times, most recently from ce80f5e to f29ce17 Compare January 20, 2024 17:38
@lahma lahma marked this pull request as ready for review January 20, 2024 17:45
@lahma lahma marked this pull request as draft January 21, 2024 07:37
@lahma lahma marked this pull request as ready for review January 21, 2024 08:03
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Much appreciated!

@sfmskywalker sfmskywalker merged commit 832fac4 into elsa-workflows:main Jan 21, 2024
2 checks passed
@lahma lahma deleted the nuke branch January 21, 2024 12:51
lahma added a commit to lahma/elsa-core that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants