-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Directory.Build.props #4828
Conversation
4fd03fe
to
dc6db50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had seen build props before, but I didn't know about the convention that it is included in all projects like this without having to explicitly import them. Nice!
I'll wait for you to mark the PR as Ready for review before merging. |
b4e0252
to
1a19eb4
Compare
So I went further down the rabbit hole and removed the If |
0d9bcd9
to
b449854
Compare
b449854
to
68beb5c
Compare
OK so many files have changed, but hopefully they are quite consistent 🫠 |
This approach is a great way to minimize those "dependency hell" scenarios. We've started using this in our projects, it makes managing versions much easier. Ps. You can override on a project-level by adding |
My hope is to tackle the versioning more deeply with a different PR converting to Central Package Management, which should improve things a bit too. |
I agree, let's move them to the same level. |
By replacing
common.props
withDirectory.Build.props
build will adhere to the more modern way of doing things.Directory.Build.props
is inherited to sub-directories and sets the properties. No need for or to remember a separate import.