Bulk Dispatch Workflows Enhancements #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new BatchProcessing sample project has been added demonstrating how to process items in batches. ForEach and ParallelForEach activities were updated to allow using an IAsyncEnumerable as source. BulkDispatchWorkflows was also refactored to improve its efficiency and handling.
This update includes adding an optional input parameter to the ScheduleChildActivity signal's constructor in order to pass options to the child activity. The input parameter is used while scheduling activities in FlowFork.cs and Flowchart.cs activities. This enables clearer data transfer and scheduling in the system.
The version of Elsa.Studio and Elsa.Studio.Login.BlazorWasm in the Elsa.ServerAndStudio.Web project has been upgraded from 3.0.2 to 3.0.3. This update aims to incorporate the latest features and bug fixes from these packages.
Modified code formatting to enhance readability in several files including integration tests and workflow definitions. Order of project references in both Elsa.sln and Elsa.Server.Web.csproj files were rearranged. Unnecessary namespaces were also removed in BulkSuspendedWorkflow.cs and _build.csproj file saw a minor adjustment.
This update adds new keys to the default background activity invoker for task completion and bookmarks. It also modifies handling of dispatched workflow instances in BulkDispatchWorkflows activity. It further updates the BackgroundActivityInvokerMiddleware to capture and remove additional task details from the workflow execution context. Refactors are made to ObjectConverter and a set method for background completion is added to ActivityExecutionContextExtensions and BackgroundActivityExecutionContextExtensions.
sfmskywalker
requested review from
cristinamudura,
MariusVuscanNx and
raymonddenhaan
sfmskywalker
added
elsa 3
Removed the ItemSource property and related logic in ForEachT.cs. Instead of considering two sources (Items and ItemSource) for iterations, the code now only iterates over the Items collection. Additional logic has been added to initialize Items to an empty collection when it is not set.
The version of the System.ComponentModel.Annotations package was downgraded from 6.0.0-preview.4.21253.7 to 5.0.0 in the Elsa.Workflows.Core project. This could be due to compatibility issues or to match the version used in other components of the project.
| /// <summary> | ||
| /// Gets the background outcomes. | ||
| /// </summary> | ||
| public static bool? GetBackgroundCompleted(this ActivityExecutionContext activityExecutionContext) |
There was a problem hiding this comment.
GetBackgroundCompletion
There was a problem hiding this comment.
You're right, that sounds more correct 👍🏻
| yield break; | ||
|
|
||
| var itemsType = items.GetType(); | ||
| if (itemsType.Name == "AsyncEnumerableAdapter`1") |
There was a problem hiding this comment.
Is there any way we can move away from the magic string here?
There was a problem hiding this comment.
Not that I could discover - this is an internal or even private type. That being said, we may not need this capability of sending async enumerables once we have data sets, which would be the recommended approach when sending big data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the BulkDispatchWorkflows with support for async-enumerables and adds support for background execution of the activity itself. Before this PR, the activity would remain in the Suspended state when executed from the background due to the fact that its bookmarks were not synced with the persisted state.