LogRecord storage at differents levels #4911
Conversation
…ord-configuration
update ActivityMapper Implementation
There was a problem hiding this comment.
Looks good, just a small request to revisit the naming of "persistence strategy" etc. to be more specific in order to indicate that this is about persisting log records. Otherwise, it might be confusing where we think that this is about persistence in general.
src/clients/Elsa.Api.Client/Resources/WorkflowDefinitions/Enums/PersistenceStrategy.cs
Outdated
Show resolved
Hide resolved
Updated various aspects of the PersistenceTab class and its functionality to improve code quality and readability. Simplified the handling of persistence configurations and simplified the use of properties. Transitioned project reference for Elsa.Api.Client from package reference to direct project reference for better development experience in Elsa.Studio.Core.
/**
Because the entire workflow is considered as an activity, the schema must be the same
ie with
"logPersistenceMode": {
"default": "default",
}
**/
- fix logic to get the default persistence mode working for the whole activity.
…ord-configuration # Conflicts: # src/modules/Elsa.MassTransit.RabbitMq/Features/RabbitMqServiceBusFeature.cs
…ord-configuration # Conflicts: # src/modules/Elsa.MassTransit.RabbitMq/Features/RabbitMqServiceBusFeature.cs
|
@jdevillard We will merge this once you give us the green light! |
…tion' into enhancement/log-record-configuration
|
Ok I found the issue about yesterday demo , it was one case when you revert Workflow Configuration to "Default" so the value of the property was LogPersistenceMode.Default and not LogPersistenceMode.Include or LogPersistenceMode.Exclude so the information was loosed when the algo have to record or not the data. So now I think It's ok for me ! thx a lot ! |
|
Awesome, great job @jdevillard . Many thanks for this! |
…ord-configuration # Conflicts: # src/modules/Elsa.Workflows.Management/Features/WorkflowManagementFeature.cs
This PR init the capability to choose if we want to store input properties and payload (output) of activity in the Activity Execution Log Record regarding the #4799
This PR is necessary for the UI development :