Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Elsa workflow expression serialization #4930

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

sfmskywalker
Copy link
Member

Added serialization support for expressions in Elsa workflows, enabling serialization and deserialization to maintain consistent types across sessions. Updated relevant test cases for validation.

Fixes #4920

Added serialization support for expressions in Elsa workflows, enabling serialization and deserialization to maintain consistent types across sessions. Updated relevant test cases for validation.
@sfmskywalker sfmskywalker added bug Something isn't working elsa 3 This issue is specific to Elsa 3 labels Feb 12, 2024
The PR workflow has been removed from GitHub actions.
@sfmskywalker sfmskywalker merged commit 3bad8a5 into main Feb 12, 2024
1 check passed
@sfmskywalker sfmskywalker deleted the issue(4920) branch February 12, 2024 17:47
@lahma
Copy link
Contributor

lahma commented Feb 17, 2024

With removal of pr.yml, didn't you lose the ability check whether PR code compiles and passes tests?

@sfmskywalker
Copy link
Member Author

Now that you mention it, I should probably not have done that 😄
I only considered the PR generator bot that I wanted to disable.
Anyway, thanks for pointing it out 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JSON value could not be converted to Elsa.Expressions.Models.MemoryBlockReference
2 participants