Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced messaging to running instances #4941

Merged
merged 28 commits into from
Feb 22, 2024

Conversation

raymonddenhaan
Copy link
Contributor

This feature will allow communication across nodes in a multi-node environment. Enabling features such as cancelling dispatched workflows and caching implementations.

@raymonddenhaan raymonddenhaan requested review from sfmskywalker and a team February 14, 2024 10:17
@raymonddenhaan raymonddenhaan added the enhancement New feature or request label Feb 14, 2024
@raymonddenhaan raymonddenhaan requested review from cristinamudura and MariusVuscanNx and removed request for a team February 14, 2024 14:02
The names for properties related to instance heartbeats have been refactored, providing clearer semantics. 'InstanceHeartbeatRhythm' changed to 'Interval', and 'HeartbeatTimeoutPeriod' to 'Timeout'. This change impacts the property name in the HeartbeatOptions class and anywhere else it is referenced, including the appsettings.json file.
Major refactoring done across several files in the src/modules directory. This includes simplifying complex sections of code, removing extraneous comments, and improving the clarity of existing comments. In addition, method names and certain variable names were updated to more accurately reflect their function.
# Conflicts:
#	src/modules/Elsa.MassTransit.AzureServiceBus/Features/AzureServiceBusFeature.cs
#	src/modules/Elsa.MassTransit.RabbitMq/Features/RabbitMqServiceBusFeature.cs
#	src/modules/Elsa.MassTransit/Features/MassTransitWorkflowDispatcherFeature.cs
#	src/modules/Elsa.MassTransit/Implementations/MassTransitWorkflowDispatcher.cs
#	src/modules/Elsa.MassTransit/Services/MassTransitWorkflowCancellationDispatcher.cs
#	src/modules/Elsa.Workflows.Runtime/Responses/DispatchWorkflowDefinitionResponse.cs
@raymonddenhaan raymonddenhaan merged commit 2710d6e into main Feb 22, 2024
6 checks passed
@raymonddenhaan raymonddenhaan deleted the feature/service-bus-pub-sub branch February 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants