Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setting updated and finished date on workflow instance #4943

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

raymonddenhaan
Copy link
Contributor

@raymonddenhaan raymonddenhaan commented Feb 14, 2024

Fixes #4950

@raymonddenhaan raymonddenhaan requested review from a team, sfmskywalker, cristinamudura and MariusVuscanNx and removed request for a team February 14, 2024 14:01
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a small change request 👍🏻

@raymonddenhaan raymonddenhaan force-pushed the fix/last_executed_on_cancellation branch 3 times, most recently from 93ee053 to aa5afe8 Compare February 15, 2024 13:35
@sfmskywalker sfmskywalker added elsa 3 This issue is specific to Elsa 3 bug Something isn't working labels Feb 15, 2024
@raymonddenhaan raymonddenhaan force-pushed the fix/last_executed_on_cancellation branch from aa5afe8 to a38176e Compare February 16, 2024 08:37
@raymonddenhaan raymonddenhaan force-pushed the fix/last_executed_on_cancellation branch from 9069ec4 to 1a672d8 Compare February 16, 2024 10:52
@raymonddenhaan raymonddenhaan merged commit fd45171 into main Feb 16, 2024
5 checks passed
@raymonddenhaan raymonddenhaan deleted the fix/last_executed_on_cancellation branch February 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working elsa 3 This issue is specific to Elsa 3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dates not set on cancelled workflow
2 participants