Add DryRun endpoint and workflow instance finder #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new DryRun endpoint for executing alteration plans and implemented the IWorkflowInstanceFinder interface to search for workflow instances. Refactored existing code to use new workflow instance finder service, resulting in cleaner activity implementation.
Change the conditional logic to use `IsEmpty` method on filters rather than checking if the collection `workflowInstanceIds` is empty. This ensures that matching workflow instances are correctly identified when no specific filters are set.
The WorkflowInstanceFinder service has been refactored to include a default workflow status of Running and to utilize a new method WorkflowFilterIsEmpty, which checks if the workflow instance filter is empty. This improves code readability and encapsulates the logic for determining an empty filter.
| var workflowInstanceFilterIsEmpty = WorkflowFilterIsEmpty(workflowInstanceFilter); | ||
|
|
||
| var workflowInstanceIds = workflowInstanceFilterIsEmpty | ||
| ? Enumerable.Empty<string>().ToHashSet() |
There was a problem hiding this comment.
Do we give some feedback to the user that they actually need to enter filter criteria or is this implied from the empty list that is returned?
| return workflowInstanceIds; | ||
| } | ||
|
|
||
| private bool WorkflowFilterIsEmpty(WorkflowInstanceFilter filter) |
There was a problem hiding this comment.
Why remove this from the filter itself? There we would be able to re use the logic
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| public override async Task HandleAsync(AlterationWorkflowInstanceFilter filter, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Wouldn't it be easier to add dryrun as an optional parameter to the alteration endpoint? Now we need to ensure these 2 endpoints stay the same.
|
This closes #5071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new DryRun endpoint for executing alteration plans and implemented the IWorkflowInstanceFinder interface to search for workflow instances. Refactored existing code to use new workflow instance finder service, resulting in cleaner activity implementation.
Fixes #5109