issue 5113: Allows string support for HttpFileResponse activity #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelarreAlexis
changed the title
|
I tried to resolve the merge conflict with the main branch (which is easy), but for some reason my git client won't let me push to your fork. Perhaps you can try it on your end? |
|
@DelarreAlexis I'd love to take this PR in, but for some reason your fork is protected against me so I cannot push the merge commit. I created a patch that you can apply if you want: https://gitkraken.dev/link/drafts/97ff21ae-6868-40c3-8253-b7ce6cb22d33 |
|
In case you don't have or don't want to use GitKraken, here's the patch attached: |
|
DelarreAlexis
force-pushed
the
issue/5112
branch
from
203b28a
to
7848c14
Compare
|
@jeanbaptistedalle thanks for updating the branch 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Http FileResponse" activity has a "Content" property which has the description "The file content to serve. Supports various types, such as byte array, stream, string, Uri, Downloadable and a (mixed) array of the aforementioned types ." Except that if I put a simple text, so just a "string", no file will be downloaded. The activity does not support string as indicated in the description of "Content"
Example :
http-file-response.json