Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the returned count of cancelled workflows #5181

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

raymonddenhaan
Copy link
Contributor

  • Removed dispatched child workflows from the count
  • Removed finished workflows from the count
  • Prevented dispatching a cancellation request for finished workflows as they can not be cancelled

It is still not 100% accurate, however it is less confusing to the user.
Not 100% since we can not guarantee that all dispatched cancellation requests also lead to a cancelled workflow. (Could be finished by the time we actually try to cancel it)

@raymonddenhaan raymonddenhaan requested a review from a team April 4, 2024 08:15
@sfmskywalker
Copy link
Member

sfmskywalker commented Apr 4, 2024

Perhaps we should consider adding a "Canceling" status to workflow instances. This way, we could immediately set the status of the selected workflow instances to Canceling - which would be reflected by the UI.
The UI could then potentially receive realtime updates via SignalR (or simple polling) as workflow instances become canceled.

To be clear: this would be out of scope for this PR 😄

@sfmskywalker sfmskywalker merged commit c39f2c1 into main Apr 4, 2024
6 checks passed
@sfmskywalker sfmskywalker deleted the fix/cancellation_count branch April 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants