feat(liquid): delete json filter and add filters already provided by … #5188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmskywalker
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks @jeanbaptistedalle ! I added some suggestions, but please feel free to ignore them and let me know if we should proceed to take this PR.
....Workflows.IntegrationTests/Scenarios/HttpRequestWithLiquid/HttpRequestWithLiquidWorkflow.cs
Outdated
Show resolved
Hide resolved
src/modules/Elsa.Liquid/Extensions/TemplateContextExtensions.cs
Outdated
Show resolved
Hide resolved
jeanbaptistedalle
force-pushed
the
feature/move-to-fluid-json-filter
branch
from
1e17f1d
to
bcb5472
Compare
jeanbaptistedalle
force-pushed
the
feature/move-to-fluid-json-filter
branch
from
bcb5472
to
3f82d64
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(liquid): delete json filter and add filters already provided by fluid library