Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dropdown when using a nullable enum in an activity input #5320

Merged
merged 2 commits into from
May 8, 2024
Merged

Include dropdown when using a nullable enum in an activity input #5320

merged 2 commits into from
May 8, 2024

Conversation

nickrubenstein
Copy link
Contributor

This PR is for #5313

Adds a check for a nullable enum type in StaticDropDownOptionsProvider so a dropdown works with nullable enums.

@nickrubenstein
Copy link
Contributor Author

@dotnet-policy-service agree

sfmskywalker
sfmskywalker approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@sfmskywalker sfmskywalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍🏻

@sfmskywalker sfmskywalker merged commit 33178f4 into elsa-workflows:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfmskywalker sfmskywalker sfmskywalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrubenstein @sfmskywalker