Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automated cleanup for Azure Service Bus subscriptions #5636

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

raymonddenhaan
Copy link
Contributor

@raymonddenhaan raymonddenhaan commented Jun 19, 2024

Reverted naming conventions of Azure Service Bus temporary queues and subscriptions.

This fixes being able to remove temporary queues and subscriptions from the service bus namespace based on missing heartbeats.

Added a new service that is able to clean up the entire service bus namespace

This service will use all topics which name start with elsa to clean up all

  • Topics without any subscriptions
  • Subscriptions for which the forwarding queue can not be found in the same namespace.

#fixes 5635


This change is Reviewable

An automated cleanup process has been added for subscriptions that do not have queues connected to Azure Service Bus. This new feature deletes orphaned topics and cleans up other remnants within the namespace.
@raymonddenhaan raymonddenhaan requested review from a team June 19, 2024 12:31
Use Memory transport to ensure docker image for demo purposes functions correctly.
Replaced the usage of notifications with commands in the Elsa.MassTransit.AzureServiceBus module. This included changing notification handler to command handler in methods and updating services to use the new command handlers.
@sfmskywalker sfmskywalker merged commit 0ff791a into patch/3.2.x Jun 20, 2024
6 checks passed
@sfmskywalker sfmskywalker deleted the fix/5635 branch June 20, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Temporary Azure Service Bus subscriptions are not being deleted
2 participants