Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActivityNodeIds filter to journal requests #5741

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

sfmskywalker
Copy link
Member

@sfmskywalker sfmskywalker commented Jul 10, 2024

This commit introduces the ActivityNodeIds filter to the journal request models. This enhancement allows filtering logs based on specific activity node IDs, providing more granular control over workflow instance logs. Additionally, unnecessary summary comments have been removed for clarity.


This change is Reviewable

This commit introduces the ActivityNodeIds filter to the journal request models. This enhancement allows filtering logs based on specific activity node IDs, providing more granular control over workflow instance logs. Additionally, unnecessary summary comments have been removed for clarity.
Copy link
Contributor

@raymonddenhaan raymonddenhaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the application of the ActivityNodeIds, or am I overlooking something?

@sfmskywalker
Copy link
Member Author

I had to take another look too, but it's right here:
image

@sfmskywalker sfmskywalker merged commit dc89cae into patch/3.2.x Jul 10, 2024
6 checks passed
@sfmskywalker sfmskywalker deleted the bug/248 branch July 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants