Add ExpandoObjectConverter for JavaScript object conversion #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced `ConverterHelper` and `ExpandoObjectConverter` to handle conversions from .NET dynamic objects to JavaScript objects. Updated integration tests to validate the conversion and sorting functionalities. Fixes #5895
raymonddenhaan
approved these changes
Aug 14, 2024
|
|
||
| internal static class ConverterHelper | ||
| { | ||
| public static ObjectInstance ConvertToJsObject(Engine engine, IDictionary<string, object?> expando) |
There was a problem hiding this comment.
Should we make this internal as well?
|
|
||
| internal static class ConverterHelper | ||
| { | ||
| public static ObjectInstance ConvertToJsObject(Engine engine, IDictionary<string, object?> expando) |
There was a problem hiding this comment.
This method is missing a summary
|
|
||
| internal class ExpandoObjectConverter : IObjectConverter | ||
| { | ||
| public bool TryConvert(Engine engine, object value, out JsValue result) |
There was a problem hiding this comment.
Should we make this internal as well?
|
|
||
| internal class ExpandoObjectConverter : IObjectConverter | ||
| { | ||
| public bool TryConvert(Engine engine, object value, out JsValue result) |
There was a problem hiding this comment.
This method is missing a summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
ConverterHelperandExpandoObjectConverterto handle conversions from .NET dynamic objects to JavaScript objects. Updated integration tests to validate the conversion and sorting functionalities.Fixes #5895
This change is