-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front matter support #58
base: master
Are you sure you want to change the base?
Conversation
Nice, that's a good progress 😄 . autolinking is probably that one that will give you the most trouble |
So, this is done so far. The following fields are supported:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing Modtime
to accept boolean has triggered many changes in this PR. I would like to think a bit about avoiding it
After merging the other PRs it conflicted with this PR, I think there were duplicate changes between them |
Yes, at first i just changed to be like |
Hey, I was thinking about making the regex change. It just occur to me, that reading line-by-line would be more efficient than opening the whole file for regex parsing. Also, i was looking if there is any standard about the triple dash. It seems that it is indeed 3 dashes, and no more.
|
I still can't accept the fact that we have a lot of changed because we added an attribute to ModTime.
|
@@ -48,8 +54,39 @@ type Page interface { | |||
Emoji() string | |||
} | |||
|
|||
type Date struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do multiple tries until a date worked, I think we need to support more date formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look for a date parse library, which could be more flexible than the go standard library.
We need to think about removing |
I introduce |
I just ran xlog in its repository. this file is "index.md" |
By just including the frontmatter extension of goldmark, it removes the yaml header from the page when rendering the page. There still some issues, we need to work on (see discussion: #55 (reply in thread))