Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2 #8

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix #2 #8

merged 2 commits into from
May 10, 2023

Conversation

giuliasellitto7
Copy link
Contributor

Fixed ClassInspector.java

@giuliasellitto7
Fix #2
88827a7 
Fixed ClassInspector.java
emaiannone
emaiannone requested changes May 10, 2023
View reviewed changes
Copy link
Owner

@emaiannone emaiannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you mind flipping the IF (nodeToVisit == null) and calling continue? This would reduce the indentation level by one. It's just a matter of style 😄
Thanks!

emaiannone
emaiannone approved these changes May 10, 2023
View reviewed changes
Copy link
Owner

@emaiannone emaiannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approved!

@emaiannone emaiannone merged commit 74cab95 into emaiannone:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaiannone emaiannone emaiannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuliasellitto7 @emaiannone