Allow to install multiple apps #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npentrel
force-pushed
the
120
branch
2 times, most recently
from
c00b9a3
to
c7df4c8
Compare
npentrel
commented
Jun 22, 2024
modules/system/eventbus.py
Outdated
| @@ -40,10 +40,16 @@ def remove(self, event_type, event_handler, app): | |||
| if app in self.handlers: | |||
| if event_type in self.handlers[app]: | |||
| if event_handler in self.handlers[app][event_type]: | |||
| print( | |||
| "Removed event handler for {event_type}: {app.__class__.__name__} - {event_handler.__name__}" | |||
There was a problem hiding this comment.
This still needs fixing before merge
Merged
|
tested this, works for me. |
npentrel
commented
Jun 23, 2024
| @@ -86,8 +92,13 @@ def background_update(self, delta): | |||
| return | |||
| self.update_state("index_received") | |||
| if self.to_install_app: | |||
| self.install_app(self.to_install_app) | |||
| self.to_install_app = None | |||
| # We wait one cycle after background_update is called to ensure the | |||
There was a problem hiding this comment.
This feels a bit hacky but because update and draw may not be called while an app is installing I'm really not sure how else to fix it
There was a problem hiding this comment.
You're right, it is, but it makes sense. async_helpers.unblock is designed to help with this kind of thing, lemme try a spike.
There was a problem hiding this comment.
@MatthewWilkes why don't we merge this and then you can prettify it subsequently? It would be nice to have this functionality in
kliment
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #120