Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

270 complex numbers #289

Open
wants to merge 8 commits into
base: 1.0.0-rc2
Choose a base branch
from
Open

270 complex numbers #289

wants to merge 8 commits into from

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Mar 13, 2024

Closes #270

(Continuation of PR #284 targeting 1.0.0-rc1)

Added custom datatypes following the Python representation: 4+5j. It would be preferable if we could find existing adopted datatypes.

The choice of "j" to denote imaginary numbers can be discussed. Chosen here to be aligned with Python. However, if we want to generalise to quatarnions, probably "i" would be a better choice, allowing them to be represented with ("i", "j", "k"), avoiding "l" which is difficult to distinguish from 1.

Open for comments. An alternative representation would be as a JSON array with two elements: [4, 5]. There exists probably already a well-known datatype for JSON data.

@jesper-friis jesper-friis changed the base branch from 1.0.0-rc1 to 1.0.0-rc2 September 6, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant