-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argv handling broken in 3.1.20 #17720
Comments
Seems likely yes. We try to detect if Can you help is debug what that might be? This works for me with simple hello world examples. If you link your program with I'm guessing the detection is not working and |
Sure! FWIW an MEMORY64 build is also failing the same way. |
|
Python's main function is a trivial function that calls another function:
I guess the new heuristic does not take into account that main does not contain any code except for a function call. Here is a simpler reproducer that does not need pthreads. It needs two separate object files to trigger the problem, though.
The reproducer prints |
Thanks I see the bug now! |
Note that the expectations for test_metadce_mem grew because we were previously mis-detecting mem.c as not read params, when in fact it does. Fixes: #17720
Note that the expectations for test_metadce_mem grew because we were previously mis-detecting mem.c as not read params, when in fact it does. Fixes: #17720
Note that the expectations for test_metadce_mem grew because we were previously mis-detecting mem.c as not read params, when in fact it does. Fixes: #17720
Note that the expectations for test_metadce_mem grew because we were previously mis-detecting mem.c as not read params, when in fact it does. Fixes: #17720
Note that the expectations for test_metadce_mem grew because we were previously mis-detecting mem.c as not read params, when in fact it does. Fixes: #17720
Version of emscripten/emsdk:
The passing of argv is broken again on Emscripten tot-upstream. The issue is similar to #17338 . The bug was likely introduced in the last 24 to 48 hours. I'm running CPython builds and tests with Emscripten latest and tot-upstream in my project https://github.com/tiran/cpython-wasm-test . The previous nightly run was fine, today's nightly run failed for builds with pthreads.
The text was updated successfully, but these errors were encountered: