Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD dependency in the MSP module (compiling without OSD not possible) #555

Open
raemin opened this issue May 7, 2021 · 0 comments
Open

Comments

@raemin
Copy link

raemin commented May 7, 2021

Describe the bug
As discussed on discord, there is an OSD depency in the MSP module that prevents to compile emuflight without the OSD feature.

To Reproduce
add to \src\main\target<TARGET>\target.h

#undef USE_OSD

Expected behavior
Compile error on MSP.c

    if (osdWarnGetState(OSD_WARNING_DJI)) {
        sbufWriteString(dst, djiWarningBuffer);
        break;
    }

I managed to make it do with the following hack:

#ifdef USE_OSD
if (osdWarnGetState(OSD_WARNING_DJI)) {
sbufWriteString(dst, djiWarningBuffer);
break;
}
#endif

Additional context
My old DTFc / DOGE F3 flight controller does not have OSD. Current Master does fit nicely in the memory once OSD is removed.

nerdCopter added a commit to nerdCopter/EmuFlight_nerdRepo that referenced this issue May 8, 2021
nerdCopter added a commit to nerdCopter/EmuFlight_nerdRepo that referenced this issue May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant