Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Notch #785

Draft
wants to merge 7 commits into
base: emuflight-1.0.0-master
Choose a base branch
from

Conversation

nerdCopter
Copy link
Member

Autonotch is code that automatically decides how much the notch filter is crossfaded with its input signal. By determining the amount of noise at the notch frequency we can set up a limit. As noise approaches that limit the notch filter is used more, as noise is low it isn't used. This will automatically phase out rpm and dynamic notch filters that to do not have much use. This should reduce delay and turn off the effect of notch filters that are doing nothing.

To test you have new rpm_noise_limit, and dyn_notch_noise_limit, both of which determine how much noise can pass through before the notch filter is fully turned on. A higher value allows more noise to pass through before the notch filter takes full effect, smaller values happen sooner.

@nerdCopter nerdCopter changed the base branch from master to emuflight-1.0.0-master March 29, 2022 19:39
@nerdCopter nerdCopter changed the title 20220329 cherry pick auto notch Auto Notch Mar 29, 2022
@nerdCopter nerdCopter marked this pull request as draft May 2, 2022 13:17
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from cd308b0 to ceaee39 Compare May 26, 2022 13:30
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from ceaee39 to 511c079 Compare May 26, 2022 15:50
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from 511c079 to 217eaf9 Compare June 2, 2022 15:03
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch 2 times, most recently from 0c4ee8b to 3aab740 Compare June 11, 2022 20:52
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from 217eaf9 to 7561e98 Compare July 6, 2022 16:22
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from 7561e98 to a87fd2c Compare July 15, 2022 14:47
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch 2 times, most recently from fe70257 to fe7710c Compare November 22, 2022 19:11
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Auto_Notch branch from a87fd2c to 0ee1886 Compare November 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants