Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from gyro to pid adds a lot of nonlinear changes to the signal, therefore gyro filtering and pidsum filtering are different. Dynamic dterm, tpa, and more all have different effects on the pidsum. By running the dynamic notch on the pidsum instead of on the gyro we can better account for the effect that pids have on the signal. AKA this will filter PID, just like we do when filtering the gyro, but it will better filter for the specific ratio of PID and any extra dynamics like TPA, anti-gravity, etc. In other words this in theory should work a bit better than just filtering the gyro with a dynamic notch.