-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emuflight 1.0.0 master rust #866
base: emuflight-1.0.0-master
Are you sure you want to change the base?
Emuflight 1.0.0 master rust #866
Conversation
* github actions workflow * Makefile
Rewrote encoding.c's zigzagEncode and castFloatBytesToInt in Rust Added a basic Makefile integration to the rust sources Ensured the unit tests pass on host
Suggested by Michael Bryan ( https://github.com/Michael-F-Bryan/ )
a29d856
to
2f1197a
Compare
2f1197a
to
bb7e492
Compare
@saidinesh5 , does |
@nerdCopter this is weird error still. Makefile automatically deciding to compile the generated rustemu.h and failing..
|
without rust installed locally, i do sill have the
|
Yeah you need to install rust first. It is complaining about missing cargo command. For me locally the rust side builds just fine. the tests are another story though |
@nerdCopter what would it take to get this merged? This I do believe would become a big point that would help separate us from other firmware. |
fe70257
to
fe7710c
Compare
@nerdCopter any luck building this? |
nope. rust installed via this method: https://rustup.rs/
then ran |
Here's a pull request for how to get started with Rust Integration in EmuFlight 1.0.0 . The code size is still slightly higher (~1kb) But overall, the integration was smooth. The idea is we move more and more functions to the rustemu crate (and delete them from the C codebase)
To test this out,
Let me know if there are any issues, so I can fix them before this is merged.