Add does_not_exist_at_server field to per-resource error state #14900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisuissa
reviewed
Feb 1, 2021
Signed-off-by: Lidi Zheng <[email protected]>
Signed-off-by: Lidi Zheng <[email protected]>
lidizheng
force-pushed
the
do-not-exist
branch
from
cc413c6
to
7247c89
Compare
markdroth
reviewed
Feb 1, 2021
lizan
reviewed
Feb 1, 2021
api/envoy/admin/v3/config_dump.proto
Outdated
| // This resource is not included in the update or being explicitly removed by | ||
| // an update, either case means that this resource no longer existed in the | ||
| // xDS server. For more information, please refer to the :ref:`"Knowing When a | ||
| // Requested Resource Does Not Exist" <xds_protocol_resource_not_existed>` |
There was a problem hiding this comment.
You can find the live version: https://www.envoyproxy.io/docs/envoy/latest/api-docs/xds_protocol#knowing-when-a-requested-resource-does-not-exist
htuch
reviewed
Feb 2, 2021
Signed-off-by: Lidi Zheng <[email protected]>
lidizheng
force-pushed
the
do-not-exist
branch
from
2abf939
to
94fd66f
Compare
lidizheng
commented
Feb 3, 2021
There was a problem hiding this comment.
@adisuissa @htuch @markdroth PTAL.
As suggested, the does not exist is added as a status enum in config_dump.proto.
htuch
reviewed
Feb 3, 2021
markdroth
reviewed
Feb 3, 2021
Signed-off-by: Lidi Zheng <[email protected]>
Signed-off-by: Lidi Zheng <[email protected]>
|
@htuch @markdroth PTALA. |
Signed-off-by: Lidi Zheng <[email protected]>
|
@lidizheng can you fix format and get CI passing? Thanks! |
lizan
previously approved these changes
Feb 4, 2021
Signed-off-by: Lidi Zheng <[email protected]>
|
@htuch Sorry for the trouble, I have fixed the format and doc generation. PTALAA. |
htuch
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add does_not_exist_at_server field to per-resource error state
Additional Description:
Risk Level: N/A
Testing: N/A
Docs Changes: Added with proto definition
Release Notes: Add does_not_exist_at_server field to per-resource error state for config dump
Platform Specific Features: N/A
CC @htuch @markdroth