Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support contract not deployed #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

challet
Copy link
Contributor

@challet challet commented Jan 2, 2023

Is your pull request closing an issue?

No

Please explain the main changes of your pull request

ether.js Contract.deployed function can throw an error about the contract not being deployed.

This adds a new error type CONTRACT_NOT_DEPLOYED for this case with the address having been requested as a context.

Checklist

  • Have you added any new returned codes to the README file ?

@codecov-commenter
Copy link

Codecov Report

Merging #43 (94c0d52) into main (d4e452b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          666       693   +27     
  Branches        79        84    +5     
=========================================
+ Hits           666       693   +27     
Impacted Files Coverage Δ
lib/__tests__/getParsedEthersError.test.ts 100.00% <100.00%> (ø)
lib/constants.ts 100.00% <100.00%> (ø)
lib/utils/getTopLevelKnownError.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@enzoferey
Copy link
Owner

Hey @challet ! Thanks for the PR 🙏🏻

I'm a bit busy these day, but I will look at it as soon as possible 👍🏻

@challet
Copy link
Contributor Author

challet commented Jan 4, 2023

Hi @enzoferey, you're welcome. When you have time, I would be glad to have your opinion on it : the error format I'm testing comes from a Ganache backend and I'm not totally confident it would work everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants