Comments from full package review Tests #121
Comments
jd-otero
added a commit
that referenced
this issue
Jun 18, 2024
Add comments to tests explaining what us being tested #121
Merged
jd-otero
added a commit
that referenced
this issue
Jun 24, 2024
* Update tests comments Add comments to tests explaining what us being tested #121 * Commit with styler
jd-otero
added a commit
that referenced
this issue
Jul 30, 2024
* Dev generals pkg review (#125) * All comments for general changes have been implemented. * Automatic readme update --------- Co-authored-by: GitHub Action <[email protected]> * Modify download_population_projections.R file (#126) Now, dynamic sized data.frame is a list. * Revert "Dev generals pkg review (#125)" (#129) This reverts commit ff9c60f. * Revert "Modify download_population_projections.R file (#126)" (#130) This reverts commit 34d99be. * Dev generals pkg review (#133) * Comments from full package review Vignettes & pkgdown (#134) * Modify download_population_projections.R file (#132) * Update climate comments from package review 2 (#128) * Update tests and snapshots * Separate dictionaryfunctions Separate dictionaries and climate tags list * Fix minimum temperature errors * Update vignettes * Change dynamic sized data.frame Also, include the initial date for climate data consultation and separate climate assertion function * Change list formatting * Replacement of dplyr::do (#135) * Modification of dplyr::do * Delete utils-pipe.R * fixed errors * Update NAMESPACE * fixed errors * add dplyr:: before calling the function * Update download_geospatial.R * Updates of lint and license (#137) * Updated lint-changed-files.yml and LICENSE.md * Update .lintr * Dev climate pkg rev 2 (#136) * Update tests and snapshots * Separate dictionaryfunctions Separate dictionaries and climate tags list * Fix minimum temperature errors * Update vignettes * Change dynamic sized data.frame Also, include the initial date for climate data consultation and separate climate assertion function * Change list formatting * Update download_geospatial.R * Enhance divipola (#138) As a response to comments in #115 , we have: - Removed dynamic sized vectors - Extract functions from loops (when possible) - Remove unnecessary for loops - Allow consultation of municipalities codes from one unique department with multiple municipalities - Avoid code repetition by creating an auxiliary function * Update tests comments (#139) * Update tests comments Add comments to tests explaining what us being tested #121 * Commit with styler * Dev httr rem (#141) * Remove httr2 and readr Replaced the usage of these libraries with utils read functions * Update CITATION.cff * Update snapshots * Update Climate download (#144) * Dev standard syntax (#143) * Dev dictionaries local (#145) * Changes to have dictionaries locally, not in the server. * Commit with styler * more changes * climate changes * fix test * R files for files associated to dictionaries * Commit with styler * modify .R files * update tests * Update _pkgdown.yml * other update in _pkgdown.yml * more changes * more updates * Add dictionaries and climate tags Add geospatial dictionaries and climate tags in both Spanish and English * Small corrections on data * changes to have dictionaries and datasets description files in english and spanish, locally * commit with styler * man changes * fixed errors * fixed errors * moore fixed * spelling errros fixed * changes * modifications in functions * more updates * changes with styler * fixed issues * changes * updates * updates * update climate_tags function and file * updates * Fix ASCII characters in data * Update snapshots * Update documentation.R * updates in functions * commit with styler * fix errors * look upp update * Update config.yaml --------- Co-authored-by: jd-otero <[email protected]> * Update DESCRIPTION * Update .lintr * Update lintr * Update config.yaml * Commit with styler * Update CITATION.cff * Update DESCRIPTION * Update CITATION.cff * Update documentation.R * Update documentation.R * Update lintr * Update lint-changed-files.yaml * Update .lintr * fixed lintr errors * fixed lintr errors * fixed lintr errors * fixed lintr errors * lintr errors * lintr errors * fixed lintr errors * fixed lintr errors * update look_up * fixed look_up lintr errrors * fixed lintr * fixed lintr errrors * fixed more lintr errors --------- Co-authored-by: M. Camila Tavera-Cifuentes <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: macataci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: