Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of the scenario class #6

Merged
merged 16 commits into from
Jan 16, 2023

Conversation

pratikunterwegs
Copy link
Collaborator

@pratikunterwegs pratikunterwegs commented Jan 12, 2023

This pull request includes developments related to the scenario class implementation sketched out in #3.

  1. Scenario class structure modified to a four element list of model_function, parameters, data, and replicates.
  2. A run_scenario function that populates the data column with model data (essentially creating a new scenario object, requires assignment).
  3. A number of helper functions, some of them discussed in Design of helper functions #5 that access scenario parameters and scenario data, and aggregate scenario data by some grouping variables.
  4. Fixes JSON import-export for scenario objects #7 by adding import-export functions to allow writing scenario objects (with or without data) to JSON files.
  5. 100% test coverage reported from covr::package_coverage().

@pratikunterwegs pratikunterwegs self-assigned this Jan 12, 2023
@pratikunterwegs pratikunterwegs added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 12, 2023
@pratikunterwegs pratikunterwegs marked this pull request as ready for review January 13, 2023 13:30
@pratikunterwegs pratikunterwegs changed the title Implementation of the scenario class Initial implementation of the scenario class Jan 13, 2023
@pratikunterwegs pratikunterwegs merged commit 362e6e8 into main Jan 16, 2023
@pratikunterwegs pratikunterwegs deleted the feature/scenario-class branch January 16, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON import-export for scenario objects
2 participants