Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: The <form> element now always exposes the role "form" #1031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julienw
Copy link

@julienw julienw commented Mar 15, 2024

This has been changed in the ARIA spec in
w3c/html-aria#402.

See also testing-library/dom-testing-library#1293

Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: b06b77e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eps1lon
Copy link
Owner

eps1lon commented Mar 15, 2024

Can you add a test for the name computation? Or do we already have one?

@eps1lon eps1lon changed the title fix: The <form> element now always exposes the role "form" chore: The <form> element now always exposes the role "form" Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants