Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolve presentational role conflicts when ARIA attributes are used #436

Merged
merged 12 commits into from
Sep 21, 2020

Conversation

eps1lon
Copy link
Owner

@eps1lon eps1lon commented Sep 21, 2020

Treat <img alt /> as role="presentation" while implementing presentational role conflicts when using global ARIA attributes.

@eps1lon eps1lon added the bug Something isn't working label Sep 21, 2020
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2020

🦋 Changeset is good to go

Latest commit: dc59187

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eps1lon eps1lon changed the title fix: Treat presentational images with role="presentation" feat: Resolve presentational role conflicts when ARIA attributes are used Sep 21, 2020
@eps1lon eps1lon added enhancement New feature or request and removed bug Something isn't working labels Sep 21, 2020
@eps1lon eps1lon merged commit 96d4438 into main Sep 21, 2020
@eps1lon eps1lon deleted the fix/presentational-img branch September 21, 2020 19:22
@github-actions github-actions bot mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants