feat: support "none" role as a synonym for the "presentation" role
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 162a2f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Just getting my head around the codebase, let me know if would like some test coverage in the likes of https://github.com/eps1lon/dom-accessibility-api/blob/main/sources/__tests__/getRole.js |
|
Yeah there should be a test for the public API |
1 similar comment
|
Yeah there should be a test for the public API |
eps1lon
reviewed
May 28, 2023
|
@eps1lon anything else needed with this one? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #932
Adding equivalent behaviours for the role of
"none"where there is existing precedent for how to deal with the"presentation"role.REF: https://rawgit.com/w3c/aria/stable/#none