-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support "none"
role as a synonym for the "presentation"
role
#933
feat: support "none"
role as a synonym for the "presentation"
role
#933
Conversation
🦋 Changeset detectedLatest commit: 162a2f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Just getting my head around the codebase, let me know if would like some test coverage in the likes of https://github.com/eps1lon/dom-accessibility-api/blob/main/sources/__tests__/getRole.js |
Yeah there should be a test for the public API |
1 similar comment
Yeah there should be a test for the public API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@eps1lon anything else needed with this one? |
Fixes #932
Adding equivalent behaviours for the role of
"none"
where there is existing precedent for how to deal with the"presentation"
role.REF: https://rawgit.com/w3c/aria/stable/#none