Ensure types are declared first in exports field

[eps1lon]

Flagged by https://publint.dev/[email protected]
/cc @hiebj

[changeset-bot]

🦋 Changeset detected

Latest commit: 5fcf56a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
dom-accessibility-api	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[hiebj]

I heard this mentioned in a throwaway comment in a thread somewhere when I was researching this issue, but the comment provided no sources and I could not find a specific reference in TypeScript documentation that states it as a requirement or explains why it is necessary.

That being said the change should be harmless so if this is the way it's supposed to be you should do it!

[eps1lon]

but the comment provided no sources and I could not find a specific reference in TypeScript documentation that states it as a requirement or explains why it is necessary.

It's a bit hidden under https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing:

The "types" condition should always come first in "exports".

It doesn't provide the "why" but I'm fine just taking their word for it.

[hiebj]

The publint link explains it and provides a link to Typescript docs, that's very helpful, although the TS docs themselves only mention it in an aside with no rationale!

Publint says it is because it is order based so you want the types to resolve first. I don't get this exactly since it worked just fine (on my machine 😅) the other way. But I am also fine just taking their word for it, I did not test with many different versions of TypeScript.