Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for this extensive and in-depth work.
I will try to keep my comments concise.
This might make them sound arrogant, apologies if that's the case, it's definitely not the intent.
(you could prefix any sentence below with: imho)
This PR touches one of the most challengeable founding choices of GraphQL: having 2 different type systems for input and output.
I understand that the sender -> receiver relation is an unbalanced one: the sender has obligations, the receiver has options.
However:
The "lack of polymorphism on input" is only a side-effect of the aformentioned original choice.
In an unreal world, rather than tweak GraphQL to fix that, it would be time for GraphQL2, unifying input and output types (amongst other improvements).
That's very unlikely to happen, but saying so helps forming an opinion on the various proposals:
From there, I think proposal 5 @OneOf is the most useful one:
!!! IMPORTANT !!!
Please Read https://github.com/graphql/graphql-spec/blob/master/CONTRIBUTING.md before creating a Pull Request.