-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): redux-simple-router + universal-redux npm package #685
Conversation
…eed them here now
…ot having access to bootstrap
Related code of |
wasn't this supposed to also fix the redirect loop on IE9? |
@Ghostavio If you're referring to #416, I believe redux-router 1.0.0-beta5 fixes the issue, but that shouldn't apply with this PR since redux-router has been removed. I noticed that I had a stale push to Heroku and have updated it. Can you try again at https://universal-redux.herokuapp.com ? I tested it and it seemed to function normally on Browserstack running Windows 7 IE9. |
Yes, sorry, it's working just fine, thanks :) |
Just a note for posterity: this is a huge change, so it's under heavy scrutiny. I have a project to bootstrap and will give it a spin on there. I'd love to hear any feedback from other people on their experience with the npm module. I think it's a great idea, but it can open up a new class of problems, sot it'd be great to get as much early feedback as possible. If it works out well, we could maybe cut a different beta version that depends on the module, or some other path. Also, I wouldn't feel comfortable merging this without discussing with @erikras. I believe he's involved in other matters at the moment. |
@quicksnap all very sensible. also, i would see this issue as a blocker for now: bdefore/universal-redux#7 i'm currently investigating. |
@quicksnap all of my 0.x changes are now merged into the 1.x code (on master) ... you should be good to go aside from the issue mentioned above. |
Are here any plans to merge this PR? @erikras ? |
Since I didn't get which PR shold be commented upon, I'll just copy & paste my comment here too: Is As for the movement towards an npm package - that's a must. Where the demarkation line should be drawn is another question. |
@andresgutgon universal-redux takes a very similar approach to that PR. it also supports async-props as of version 3.0.0-rc5. |
Great, sorry I saw it after comment here. It's great your work on |
@andresgutgon It's just very fat PR, my is much smaller and i believe it's in the same direction. |
I'm going to close this PR as it's superseded by #759 Please direct any further comments over there. |
Some of you might have seen my
universal-redux
npm package: https://github.com/bdefore/universal-redux .. there's another PR out for it here: #626. It extracts away a lot of Webpack, Express, and universal rendering from this project, and leaves behind just the parts from the example project itself, plus the API server. But that PR stays withredux-router
which the community is starting to move away from in lieu ofredux-simple-router
.I've just released a
1.0.0-beta1
version which switches to usingredux-simple-router
, following along much of the steps of @jlongster 's PR fork: reactjs/react-router-redux#13What's nice about this is that those who have used this project as a boilerplate who'd like to stay with redux-router can pin to
^0.16
ofuniversal-redux
while further development can proceed with usingredux-simple-router
by requiring^1.0.0-beta1
. It also extracts ApiClient into a more formal redux middleware, which would make exploringredux-fetcher
easier to do.I've deployed it here: http://universal-redux.herokuapp.com
Far as I can see everything seems to work great (Widget, Chat, routing).